Allow inputs for workflow_calls #1845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81cb660 to
0d4f719
Compare
Contributor
|
@GuessWhoSamFoo this pull request has failed checks 🛠 |
Codecov Report
@@ Coverage Diff @@
## master #1845 +/- ##
==========================================
+ Coverage 61.22% 62.65% +1.42%
==========================================
Files 46 51 +5
Lines 7141 8209 +1068
==========================================
+ Hits 4372 5143 +771
- Misses 2462 2677 +215
- Partials 307 389 +82
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d4d5250 to
b1c986b
Compare
Contributor
Author
|
@cplee Mergify seems to be unhappy with permissions |
Contributor
|
@GuessWhoSamFoo Press "update branch" and it will continue. cplee should grant the workflow permission to mergify to prevent such weird issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1542
There's likely room to deduplicate some code in the future with generics once golang/go#48522 gets in a better spot since
WorkflowDispatchConfigandWorkflowCallConfigis iterating through inputs on shared fields. Embedding is also possible here although it would require a much larger refactor also not much gained imo.