Changed DS4 Mode Hid Descriptor to Vendor Defined and usage 0x01. Renamed mode to "DS4Windows"#71
Merged
Merged
Conversation
to DS3_DS4REV1_USB_HID_INPUT_REPORT_SIZE
Owner
|
Exciting! |
Collaborator
Author
|
Addresses #59 |
This was
linked to
issues
Apr 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The major change is that when the controller is in "DS4Windows" Mode the controller is presented as a vendor-defined device with 0x01 usage. As such, the device is not recognized by Windows and other aplications as a gamepad, meaning there's no need anymore for the user to hide the controller with HidHide/HidGuardian.
Changes on DS4Windows side were implemented for the DS3 in the new DS4Windows mode to be detected.
Besides that, some variables/definitions/comments were renamed to keep things consistent.