HotToWarmTieringService changes and changes in shard balancer to tier shards#144
Draft
neetikasinghal wants to merge 68 commits intotieringfrom
Draft
HotToWarmTieringService changes and changes in shard balancer to tier shards#144neetikasinghal wants to merge 68 commits intotieringfrom
neetikasinghal wants to merge 68 commits intotieringfrom
Conversation
neetikasinghal
commented
Jul 16, 2024
server/src/main/java/org/opensearch/common/settings/IndexScopedSettings.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java
Outdated
Show resolved
Hide resolved
| * pool. | ||
| */ | ||
| public void tierShards() { | ||
| List<ShardRouting> shardsPendingTiering = new ArrayList<>(); |
There was a problem hiding this comment.
It might be better to break this down into replicas and primary.
We can run the operation on replicas first, and the migration for primary would handle the scenario of flipping replica to primary.
(There would be a case where you have no replica - which is fine. But when you do, it is safer)
jed326
reviewed
Jul 17, 2024
...r/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/routing/allocation/allocator/ShardsBalancer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/tiering/HotToWarmTieringService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/tiering/HotToWarmTieringService.java
Outdated
Show resolved
Hide resolved
9 tasks
...c/internalClusterTest/java/org/opensearch/remotestore/tiering/HotToWarmTieringServiceIT.java
Show resolved
Hide resolved
...r/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java
Outdated
Show resolved
Hide resolved
044ea5b to
0a64950
Compare
...r/src/main/java/org/opensearch/cluster/routing/allocation/allocator/LocalShardsBalancer.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/indices/tiering/HotToWarmTieringServiceTests.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/tiering/HotToWarmTieringService.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/opensearch/cluster/routing/allocation/allocator/RemoteShardsBalancer.java
Outdated
Show resolved
Hide resolved
0a64950 to
dbb74c8
Compare
9f55e78 to
b1107ec
Compare
dbb74c8 to
fde4f91
Compare
fde4f91 to
2e9f80d
Compare
3 tasks
…arch-project#14851) Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
2e9f80d to
052d551
Compare
…roject#14812) * Use default value when index.number_of_replicas is null Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Add integration test Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Add changelog Signed-off-by: Liyun Xiu <xiliyun@amazon.com> --------- Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
…ile. (opensearch-project#14684) * Implement write and read flow to upload/download shard diff file. Signed-off-by: Shailendra Singh <singhlhs@amazon.com>
…oject#14426) * Optimize Cluster Stats Indices to precomute node level stats Signed-off-by: Pranshu Shukla <pranshushukla06@gmail.com>
…ary shards per index (opensearch-project#14908) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
…-project#14761) Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
…ch-project#14918) The test would previously fail if the randomness led to only a single indexing request being included in the bulk payload. This change guarantees multiple indexing requests in order to ensure the batch logic kicks in. Also replace some unneeded mocks with real classes. Signed-off-by: Andrew Ross <andrross@amazon.com>
…shAndMergeHeaders (opensearch-project#15051) Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
…ch distribution (opensearch-project#15082) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Resolves: opensearch-project#14706 Signed-off-by: Peter Nied <peternied@hotmail.com>
…ensearch-project#14711) --------- Signed-off-by: kkewwei <kkewwei@163.com>
…ensearch-project#15072) Signed-off-by: Jay Deng <jayd0104@gmail.com>
…ject#15037) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
…ta stream but is unused (opensearch-project#15080) * Fix delete not-using index template failed when the index pattern matches a data stream Signed-off-by: Gao Binlong <gbinlong@amazon.com> * modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix version check Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
…e failed (opensearch-project#15101) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
…pensearch-project#15110) * Bump org.tukaani:xz from 1.9 to 1.10 in /plugins/ingest-attachment Bumps [org.tukaani:xz](https://github.com/tukaani-project/xz-java) from 1.9 to 1.10. - [Release notes](https://github.com/tukaani-project/xz-java/releases) - [Changelog](https://github.com/tukaani-project/xz-java/blob/master/NEWS.md) - [Commits](tukaani-project/xz-java@v1.9...v1.10) --- updated-dependencies: - dependency-name: org.tukaani:xz dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
…NDEX_SETTING feature (opensearch-project#15076) Signed-off-by: Neetika Singhal <neetiks@amazon.com>
* Bump actions/setup-java from 1 to 4 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 1 to 4. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v1...v4) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
…#15086) GitHub doesn't suport dynamic days since created/modified, I've created a simple redirect on my website that will support this use case. See https://peternied.github.io/redirect/issue_search.html for full context on what is avaliable. Source is available on https://github.com/peternied/peternied.github.io Signed-off-by: Peter Nied <peternied@hotmail.com>
…y-hdfs (opensearch-project#15119) * Bump org.apache.avro:avro from 1.11.3 to 1.12.0 in /plugins/repository-hdfs Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
…astle:bc-fips from 1.0.2.5 to 2.0.0 (opensearch-project#15122) * Bump org.bouncycastle:bcpg-fips from 1.0.7.1 to 2.0.8 and org.bouncycastle:bc-fips from 1.0.2.5 to 2.0.0 in /distribution/tools/plugin-cli Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: David Zane <davizane@amazon.com>
…onstant_keyword field type (opensearch-project#15127) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
…y-azure (opensearch-project#15111) * Bump com.azure:azure-core in /plugins/repository-azure Bumps [com.azure:azure-core](https://github.com/Azure/azure-sdk-for-java) from 1.49.1 to 1.51.0. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-core_1.49.1...azure-core_1.51.0) --- updated-dependencies: - dependency-name: com.azure:azure-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
…ct#15134) Signed-off-by: Rishabh Singh <sngri@amazon.com>
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>
4774394 to
7da1aa6
Compare
--------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
…-project#13897) * initial code for the sandbox resource tracking and cancellation framework Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Fix Failing Tests Signed-off-by: Kiran Prakash <awskiran@amazon.com> * spotless Apply Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update SandboxService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update SandboxService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update SandboxTask.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Add java docs Signed-off-by: Kiran Prakash <awskiran@amazon.com> * spotless Signed-off-by: Kiran Prakash <awskiran@amazon.com> * javadocs Signed-off-by: Kiran Prakash <awskiran@amazon.com> * javadocs Signed-off-by: Kiran Prakash <awskiran@amazon.com> * java docs Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update AbstractTaskCancellation.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update SandboxModule.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Some tests and stubs Signed-off-by: Kiran Prakash <awskiran@amazon.com> * spotless Signed-off-by: Kiran Prakash <awskiran@amazon.com> * :server:testingConventions Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update AbstractTaskCancellation.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * more tests Signed-off-by: Kiran Prakash <awskiran@amazon.com> * addressing comments Signed-off-by: Kiran Prakash <awskiran@amazon.com> * revert some accidentally pushed files Signed-off-by: Kiran Prakash <awskiran@amazon.com> * resolve flakiness Signed-off-by: Kiran Prakash <awskiran@amazon.com> * renaming sandbox to querygroup and adjusting code based on merged PRs Signed-off-by: Kiran Prakash <awskiran@amazon.com> * jvm to memory Signed-off-by: Kiran Prakash <awskiran@amazon.com> * missing java docs Signed-off-by: Kiran Prakash <awskiran@amazon.com> * spotless Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <awskiran@amazon.com> * pluck cancellation changes out of this PR Signed-off-by: Kiran Prakash <awskiran@amazon.com> * remove unused Signed-off-by: Kiran Prakash <awskiran@amazon.com> * remove cancellation related code and add more tests coverage Signed-off-by: Kiran Prakash <awskiran@amazon.com> * us only memory and not jvm Signed-off-by: Kiran Prakash <awskiran@amazon.com> * test conventions Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Bring back enum Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update SearchBackpressureService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * revert changes Signed-off-by: Kiran Prakash <awskiran@amazon.com> * revert changes Signed-off-by: Kiran Prakash <awskiran@amazon.com> * all required changes Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <awskiran@amazon.com> * cleanups Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Delete QueryGroupService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * cleanups Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update QueryGroupLevelResourceUsageViewTests.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update QueryGroupLevelResourceUsageViewTests.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <awskiran@amazon.com> * rebasing with latest main Signed-off-by: Kiran Prakash <awskiran@amazon.com> * remove experimental Signed-off-by: Kiran Prakash <awskiran@amazon.com> * remove queryGroupId Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * change code comments Signed-off-by: Kiran Prakash <awskiran@amazon.com> * remmove QueryGroupUsageTracker Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update QueryGroupResourceUsageTrackerService.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * remove QueryGroupTestHelpers Signed-off-by: Kiran Prakash <awskiran@amazon.com> * cleanups Signed-off-by: Kiran Prakash <awskiran@amazon.com> * remove queryGroupHelper Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update ResourceTypeTests.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * extend OpenSearchTestCase Signed-off-by: Kiran Prakash <awskiran@amazon.com> * pr comments Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update CHANGELOG.md Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update QueryGroupResourceUsageTrackerServiceTests.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update ResourceTypeTests.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update ResourceTypeTests.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update ResourceType.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> * Update ResourceType.java Signed-off-by: Kiran Prakash <awskiran@amazon.com> --------- Signed-off-by: Kiran Prakash <awskiran@amazon.com>
Signed-off-by: Jay Deng <jayd0104@gmail.com>
…search-project#14234) Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
7da1aa6 to
d99f55f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
opensearch-project#14545
opensearch-project#13980
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.