Skip to content

Fix memory leaks for athena#3

Merged
nedtaylor merged 2 commits intomainfrom
fix_memory_shared_point
Nov 14, 2025
Merged

Fix memory leaks for athena#3
nedtaylor merged 2 commits intomainfrom
fix_memory_shared_point

Conversation

@nedtaylor
Copy link
Owner

Memory leaks occurred when multiple duplicated graphs pointed to the same fix_pointer arrays and were invoking the if(associated(array%grad)) clause of the accumulate_gradient_ptr() procedure.

This was simply a typo, accidentally combining array_type values with array_type%val values, meaning that the graph was not correctly being generated, so could not be properly nullified using the nullify_graph() procedure.

@nedtaylor nedtaylor self-assigned this Nov 14, 2025
@nedtaylor nedtaylor added the bug Something isn't working label Nov 14, 2025
@nedtaylor nedtaylor merged commit bf4493b into main Nov 14, 2025
@nedtaylor nedtaylor deleted the fix_memory_shared_point branch November 14, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant