fix: combine aliases on windows base dirs (ie: X:\) (fixes: #577)#1080
Merged
nedbat merged 1 commit intocoveragepy:masterfrom Jan 17, 2021
Merged
fix: combine aliases on windows base dirs (ie: X:\) (fixes: #577)#1080nedbat merged 1 commit intocoveragepy:masterfrom
X:\) (fixes: #577)#1080nedbat merged 1 commit intocoveragepy:masterfrom
Conversation
Member
|
@vaab Thanks for sticking with this! I took a quick look at the change, and it seems straightforward enough. The tests are passing here on GitHub, so it seems good. If you could add a test of the specific problem, that would be great! |
…agepy#577) Signed-off-by: Valentin Lab <valentin.lab@kalysto.org>
Codecov Report
@@ Coverage Diff @@
## master #1080 +/- ##
==========================================
- Coverage 91.30% 91.24% -0.06%
==========================================
Files 90 90
Lines 13358 13358
Branches 1493 1493
==========================================
- Hits 12196 12188 -8
- Misses 951 959 +8
Partials 211 211
|
Contributor
Author
|
Added the test as required, kept it quite simple. Thanks for your feedback. Should I worry about the coverage drop ? It seems to happen in a test file, which was seemingly untouched by my change. |
Member
|
@vaab no worries about the codecov drop. Ironically, I can't make heads or tails of those reports, and have turned them off. Thanks! |
nedbat
added a commit
that referenced
this pull request
Jan 17, 2021
Member
|
This is now released as part of coverage 5.4. |
This was referenced Mar 13, 2021
This was referenced May 21, 2021
This was referenced Jun 6, 2021
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Illustrating a valid fix for my issue, that is still happening ;-)
I had a (very quick) look at running the tests, but unfortunately I had a lot of tests failing on the pristine source prior to any change. So I figured I missed a lot of dependencies or information to get this running properly. I'm afraid that I couldn't check that I didn't break anything properly before submitting that code change.
If you think this code change is definitively worth it, I'll take the time to add tests to your convenience if required.