Report descending sort option#1005
Conversation
|
I've made you a pull request that fixes the tests: jerinpetergeorge#1 |
|
BTW, at any time, you can say, "I've done as much as I want to do," and I'll pick it up, or we can keep working together on it. |
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
==========================================
+ Coverage 94.02% 94.04% +0.01%
==========================================
Files 86 86
Lines 12152 12173 +21
Branches 1220 1224 +4
==========================================
+ Hits 11426 11448 +22
+ Misses 592 591 -1
Partials 134 134
Continue to review full report at Codecov.
|
|
Thanks! Are we good to merge? |
|
I think we are good to go. I will make another PR with a few tests that probably cover the new sort option. |
|
We can wait for tests :) |
|
Great. Let me try |
|
I'm thinking about a new release in a few days, and I'd like to get this into it. I don't mind doing the tests myself if you don't mind. |
That's so fast... Anyway, I have pushed one more commit. BTW, I came across this piece of the test. Just out of curiosity, I have changed the assert statement to something like Did I miss something here? @nedbat |
|
Wow, good catch on that broken test! I've fixed it in f28b1db, and added an assert to prevent that kind of breakage in the future. Thanks for this, I'm merging it! |
|
Welcome 😄 I hope you can handle the rest of the test cases if any |
|
This is now released as part of coverage 5.2. |
Fix #199