Skip to content

Added missing Finnish translation#151

Merged
nebojsatomic merged 2 commits intonebojsatomic:mainfrom
minna-xD:finnish
Oct 4, 2025
Merged

Added missing Finnish translation#151
nebojsatomic merged 2 commits intonebojsatomic:mainfrom
minna-xD:finnish

Conversation

@minna-xD
Copy link
Contributor

@minna-xD minna-xD commented Oct 2, 2025

I've translated the new strings into Finnish. Thanks for tagging me!

"These pages are exported!" => "Sivut on viety.",
"Choose image" => "Valitse kuva",
"Category:" => "Luokka:",
"Module:" => "Komponentti:",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minna-xD

Does Finnish have a word for Module other than Komponentti? Komponentti resembles to Components, which is a word that Joomla CMS has for its extensions, and in this project we use the word Module for a functionality that is equivalent, and all over the project the word Module is used.

If it is not much trouble, please do this change for all the occurrences of this word, if you find a suitable word for module.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minna-xD
actually, I see now that we used this word is used in the first Finnish translation too, but you do not have to edit that file, just this fi.php.missing.

I will make the adjustments later in the original file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do have a word "moduuli" as well. I remember having some reasoning for not picking the direct translation last year but nothing prevents us using "moduuli". I'll make the change in fi.php.missing!

Copy link
Owner

@nebojsatomic nebojsatomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed changes in the comment, on the word Module.

@nebojsatomic nebojsatomic linked an issue Oct 3, 2025 that may be closed by this pull request
@nebojsatomic
Copy link
Owner

@minna-xD
Could you remove this last commit "Merge branch 'nebojsatomic:main' into finnish" ?
It contains a change to another language, and it will show in the git history just as one unnecessary commit.

You can remove it from your forked local repo with ( do a fresh git clone of your forked repo first )
git checkout finnish
git reset HEAD~1

then you will have unnecessary files from Hindi translation, which you'll need to remove.
list those files with
git clean -n -d
and then, if you see only Hindi related files, remove them with
git clean -f

and then push the changes to your remote branch finnish
git push origin finnish

let me know if you can do this :)

@minna-xD
Copy link
Contributor Author

minna-xD commented Oct 4, 2025

Sorry about that! I did the sync and then realized that "oops, I probably shouldn't have done that".

I've done those commands and tried to push but it says:

failed to push some refs to <remote url>
hint: Updates were rejected because the tip of your current branch is behind its remote counterpart. 
Integrate the remote changes (e.g. 'git pull ...') before pushing again.

Git pull seems to get the Hindi files back again so what's the correct way forward?

@nebojsatomic
Copy link
Owner

@minna-xD

try everything like I described from the start ( git clone first, again )

and when it comes to push, try to do it with -f argument

git push -f origin finnish

@nebojsatomic
Copy link
Owner

@minna-xD

that seems to do the trick,
I will merge soon :)

@minna-xD
Copy link
Contributor Author

minna-xD commented Oct 4, 2025

Phew, thank you for the help!

Copy link
Owner

@nebojsatomic nebojsatomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
@minna-xD Thanks :)

@nebojsatomic nebojsatomic changed the title Update fi.php.missing Add missing Finnish translation Oct 4, 2025
@nebojsatomic nebojsatomic merged commit b0b95a9 into nebojsatomic:main Oct 4, 2025
@nebojsatomic nebojsatomic changed the title Add missing Finnish translation Added missing Finnish translation Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate the missing strings for the Finish language

2 participants