fix(frontend): show group shares in Collaborators tab#386
Merged
Conversation
The Collaborators tab on the workspace detail page fetched both user and group grants but only rendered users, so a workspace shared with a group showed nothing for that group, even though the Share dialog's Current Access list and the backend collaborators endpoint both included it. Extract a read-only CollaboratorsList component that renders users and groups (group rows show the name, native/OIDC source, and role), use it in the tab, and base the tab count on the full collaborator list.
✅ Deploy Preview for nebi-docs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sharing a workspace with a group added the group to the backend grants and showed it in the Share dialog's "Current Access" list, but the Collaborators tab on the workspace detail page rendered nothing for that group. The tab fetched both user and group grants, then only mapped over the user list, so groups were silently dropped (and the tab count excluded them).
Fix
CollaboratorsListcomponent that renders both users and groups. Group rows show the group name, its source (Native group/OIDC group), and the role badge, matching how the Share dialog already presents groups.Backend (
GET /workspaces/{id}/collaborators) already returned groups, so no server change was needed.Tests
New
CollaboratorsList.test.tsx: renders user rows, renders group rows alongside users, distinguishes native vs OIDC group labels, and shows the empty state.