fix(auth): collapse leading-slash OIDC group paths to one group#370
Merged
Conversation
Keycloak can carry two group-membership mappers on one client: full.path=true emits "/developer", full.path=false emits "developer". Both land in the `groups` claim, so SyncOIDCGroups created two groups for one Keycloak group. Strip the leading slash before upsert so the two forms dedup to a single oidc group.
✅ Deploy Preview for nebi-docs canceled.
|
viniciusdc
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Keycloak client carries both group-membership mappers (full.path=true →
/developer, full.path=false →developer), thegroupsclaim holds both forms andSyncOIDCGroupscreated two groups for one real group. Strip the leading/before upsert so they dedup to one. Adds a regression test.