Skip to content

Migrate to biome#362

Merged
jbouder merged 5 commits into
nebari-dev:mainfrom
karamba228:chore/migrate-to-biome
Jun 4, 2026
Merged

Migrate to biome#362
jbouder merged 5 commits into
nebari-dev:mainfrom
karamba228:chore/migrate-to-biome

Conversation

@karamba228

Copy link
Copy Markdown
Contributor

PR Description

  • Transitioning eslint to biome

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@netlify

netlify Bot commented May 29, 2026

Copy link
Copy Markdown

Deploy Preview for nebi-docs canceled.

Name Link
🔨 Latest commit 8dd57a6
🔍 Latest deploy log https://app.netlify.com/projects/nebi-docs/deploys/6a21e2067c9e9d000840d72b

@karamba228 karamba228 linked an issue Jun 3, 2026 that may be closed by this pull request
6 tasks
@jbouder jbouder self-requested a review June 4, 2026 17:40

@jbouder jbouder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update as below, then run another npm run format:fix

Comment thread frontend/biome.json Outdated

@jbouder jbouder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing. The test files have inconsistent formatting. Some have spaces and some have tabs. My suggestion would be to remove this "!**/*.test.tsx" from biome.json, then run a format:write.

@jbouder jbouder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jbouder jbouder merged commit bb45aed into nebari-dev:main Jun 4, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Biome for Formatting & Linting

2 participants