ci(desktop): smoke-test built binaries by launching them for 10s#358
Merged
Conversation
Build-only CI doesn't exercise runtime initialization, so issues like the WebKitGTK/JSC signal-handler SIGSEGV from #350/#351 — which only trips once the JS context lazy-inits — slip through. Add a post-build step on each OS that launches the artifact, waits 10s, and fails if it exited or crashed within that window: - Linux: xvfb-run + timeout, expect exit 124 (timed out still-running) - macOS: open Nebi.app, pgrep -x Nebi - Windows: Start-Process -PassThru, check HasExited Runs before release upload so a regression also gates v* tag releases. Adds xvfb to the Linux apt deps.
✅ Deploy Preview for nebi-docs canceled.
|
aktech
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v*tag releases too, not just PRs.How each platform decides pass/fail
xvfb-run -a timeout 10 ./build/bin/Nebi): success ifftimeoutexits 124 (still-running process killed at deadline). A SIGSEGV would exit 139, SIGBUS 138 — both fail.open Nebi.app,pgrep -x Nebiafter 10s): success iff still running.Start-Process -PassThru, checkHasExitedafter 10s): success iff false.Adds
xvfbto the Linux apt deps.Test plan