fix(rbac): drop redundant enforcer.SavePolicy() after grant/revoke#357
Merged
Conversation
AddPolicy/RemovePolicy already persist via the adapter's AutoSave (on by default), so the following SavePolicy() call is a no-op for correctness but expensive: it deletes every row in casbin_rule and bulk-reinserts every policy from the in-memory model on every grant. Also propagate the previously-swallowed errors from the two RemovePolicy calls in RevokeWorkspaceAccess.
✅ Deploy Preview for nebi-docs canceled.
|
👷 Deploy Preview for nebi-docs processing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddPolicy/RemovePolicyalready persist via the adapter's AutoSave (enabled by default). The followingSavePolicy()call is therefore unnecessary for correctness, but expensive: it deletes every row incasbin_ruleand bulk-reinserts every policy from the in-memory model on every grant.The custom in-tree adapter's
SavePolicyconfirms the cost:https://github.com/nebari-dev/nebi/blob/0afe891/internal/rbac/adapter.go#L71-L92
And
AddPolicyon the same adapter already does the single-row INSERT that AutoSave triggers:https://github.com/nebari-dev/nebi/blob/0afe891/internal/rbac/adapter.go#L94-L97
Upstream guidance: https://casbin.apache.org/docs/adapters/#autosave
Discussed on #346.
Changes
enforcer.SavePolicy()fromGrantWorkspaceAccess,RevokeWorkspaceAccess,MakeAdmin,RevokeAdmin.RemovePolicycalls inRevokeWorkspaceAccess.