Value with Callback (auto unlocks) by evgenykuzyakov · Pull Request #24 · near/NEPs

evgenykuzyakov · 2019-11-21T18:25:52Z

No description provided.

evgenykuzyakov · 2019-11-22T16:51:16Z

I was thinking about security of this and it still seems ok.

When a promise it attached to a callback, the predecessor_id doesn't change. So one contract can't fake a call to appear from a different predecessor.

text/0000-value-with-callback-return.md

Co-Authored-By: Maksym Zavershynskyi <35039879+nearmax@users.noreply.github.com> Co-Authored-By: Alexey <alexey@fckt.dev>

Co-Authored-By: Alexey <alexey@fckt.dev>

evgenykuzyakov · 2019-12-06T01:21:44Z

Please take a look again. Added diagram, receipts and separated scenarios for better explanation.

maxzaver · 2019-12-07T01:02:54Z

text/0000-value-with-callback-return.md

+
+Let's look at receipts (See [How runtime works](#how-runtime-work)):
+
+```rust


The transition to specific receipts is unclear. This pseudocode here demonstrates how receipts are created and updated during the execution of exchange method on dex. I think this should be stated more explicitly.

text/0000-value-with-callback-return.md

maxzaver · 2019-12-07T02:22:26Z

text/0000-value-with-callback-return.md

+    predecessor_id: "dex",
+    input_data_ids: [],
+    output_data_receivers: [],
+    actions: [FunctionCall { method_name: "trasnferFrom", ... }],


We need an explanation on how locks are passed to the function calls, i.e. specify the args.

Added args where it makes sense

text/0000-value-with-callback-return.md

maxzaver · 2019-12-09T03:00:09Z

text/0000-value-with-callback-return.md

+    predecessor_id: "dex",
+    input_data_ids: ["data-id-1", "data-id-2"],
+    // 2 new data receivers we added for the received input data
+    output_data_receivers: [


This is confusing. It says we don't actually add them to output_data_receivers, but just account for them. Maybe comment out this field here to empathize that it is not actually added.

We need a different name for it.

What I meant, it the receipt would look like this if we append new output data receivers to the exiting output data receivers.

maxzaver · 2019-12-09T03:24:03Z

text/0000-value-with-callback-return.md

+
+/// `dex` returns this callback (A7) using `return_promise`.
+// This modifies A7, by redirecting output from A4.
+ActionReceipt {


So this functionality is already implemented in the current runtime, when we use return_promise, correct?

maxzaver · 2019-12-09T03:47:58Z

text/0000-value-with-callback-return.md

+    id: "D5",
+    receiver_id: "fun",
+    predecessor_id: "dex",
+    data_id: "data-id-3",


Generating this receipt requires modification to the runtime, correct?

No. It's how it works. We always generate a data receipt.

text/0000-value-with-callback-return.md

lexfrl · 2019-12-09T12:05:44Z

text/0000-value-with-callback-return.md

+}
+
+/// `dex` returns this callback using `return_promise`.
+// No receipts are modified, but execution outcome for A1 changes to reflect to wait for A4.


but execution outcome for A1 changes

where I can see it?

It's part of status in ExecutionOutcome in Runtime: https://github.com/nearprotocol/nearcore/blob/d869465f0400678b5df9e29d3bd926e8887d2337/runtime/runtime/src/lib.rs#L728

evgenykuzyakov · 2019-12-09T23:57:42Z

Going to write a new NEP (in short form first). Keeping this for eduction.

Spoiler: We'll use Safes which is similar to move operator

evgenykuzyakov · 2019-12-11T18:29:52Z

WIP for the next version: #26

Evgeny Kuzyakov added 2 commits November 20, 2019 16:46

WIP. Explaining Runtime

ba880d8

Ready to review

1b0e246

evgenykuzyakov requested review from SkidanovAlex, ilblackdragon and maxzaver November 21, 2019 18:25

evgenykuzyakov mentioned this pull request Nov 22, 2019

Fungible Token standard #21

Merged

ilblackdragon reviewed Nov 23, 2019

View reviewed changes

text/0000-value-with-callback-return.md Show resolved Hide resolved

ilblackdragon mentioned this pull request Nov 23, 2019

Move operator #23

Closed

maxzaver suggested changes Nov 25, 2019

View reviewed changes

lexfrl reviewed Nov 27, 2019

View reviewed changes

text/0000-value-with-callback-return.md Outdated Show resolved Hide resolved

lexfrl reviewed Nov 27, 2019

View reviewed changes

text/0000-value-with-callback-return.md Outdated Show resolved Hide resolved

lexfrl reviewed Nov 27, 2019

View reviewed changes

text/0000-value-with-callback-return.md Outdated Show resolved Hide resolved

lexfrl reviewed Nov 27, 2019

View reviewed changes

text/0000-value-with-callback-return.md Outdated Show resolved Hide resolved

lexfrl reviewed Nov 27, 2019

View reviewed changes

text/0000-value-with-callback-return.md Outdated Show resolved Hide resolved

lexfrl reviewed Nov 27, 2019

View reviewed changes

text/0000-value-with-callback-return.md Outdated Show resolved Hide resolved

lexfrl reviewed Nov 27, 2019

View reviewed changes

text/0000-value-with-callback-return.md Outdated Show resolved Hide resolved

Evgeny Kuzyakov and others added 4 commits December 4, 2019 14:48

Apply suggestions from code review

e08eb10

Co-Authored-By: Maksym Zavershynskyi <35039879+nearmax@users.noreply.github.com> Co-Authored-By: Alexey <alexey@fckt.dev>

Apply suggestions from code review

7b7cc91

Co-Authored-By: Alexey <alexey@fckt.dev>

Add more details to examples

3457c20

Added time diagrams

9e90ad3

Highlight NOTE

657a241

evgenykuzyakov requested review from ilblackdragon, lexfrl and maxzaver December 6, 2019 01:22

Copied part of receipts from the current version

b0980e5

maxzaver suggested changes Dec 9, 2019

View reviewed changes

maxzaver reviewed Dec 9, 2019

View reviewed changes

text/0000-value-with-callback-return.md Show resolved Hide resolved

lexfrl reviewed Dec 9, 2019

View reviewed changes

lexfrl requested a review from k06a December 9, 2019 18:43

Adding more comments

518be83

evgenykuzyakov closed this Jan 17, 2020

evgenykuzyakov mentioned this pull request Jan 21, 2020

Auto-unlock with Safes #26

Closed

frol deleted the delayed-promise branch December 20, 2022 18:47


		Let's look at receipts (See [How runtime works](#how-runtime-work)):

		```rust

Conversation

evgenykuzyakov commented Nov 21, 2019

Uh oh!

evgenykuzyakov commented Nov 22, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

evgenykuzyakov commented Dec 6, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

evgenykuzyakov commented Dec 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evgenykuzyakov commented Dec 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

evgenykuzyakov commented Dec 9, 2019 •

edited

Loading