feat: expose TOKEN_ERROR_CODES and derive duplicated error code types from it#573
Merged
simoneb merged 7 commits intonearform:masterfrom Dec 1, 2025
Conversation
Contributor
|
Could you write a test for it and place it in test/types? |
Contributor
Author
|
Added tests for TOKEN_ERROR_CODES and some sanity type checks to check it is equivalent to the TokenError class usage. |
simoneb
approved these changes
Dec 1, 2025
SociableSteve
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #572
TOKEN_ERROR_CODESso IDEs recognise it as a valid export fromfast-jwtTOKEN_ERROR_CODESinstead of duplicating string literals. Ensures the exported type union (TokenValidationErrorCode) andTokenErrorclass do not accidently have differing values for an error code.