Skip to content

Fix: error constructor in declaration file#562

Merged
simoneb merged 1 commit intonearform:masterfrom
atlowChemi:fix-error-declaration-type
May 27, 2025
Merged

Fix: error constructor in declaration file#562
simoneb merged 1 commit intonearform:masterfrom
atlowChemi:fix-error-declaration-type

Conversation

@atlowChemi
Copy link
Copy Markdown
Contributor

@atlowChemi atlowChemi commented May 27, 2025

Fixes: #563

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels May 27, 2025
@simoneb simoneb requested a review from Copilot May 27, 2025 19:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the error constructor in the declaration file by adding comprehensive tests for TokenError's behavior.

  • Adds tests for TokenError constructed with no message, with a message, and with additional data.
  • Verifies that the error message and additional properties have the expected types.

Copy link
Copy Markdown
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🚀

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 27, 2025
@simoneb simoneb merged commit f28ebf9 into nearform:master May 27, 2025
7 of 8 checks passed
@atlowChemi atlowChemi deleted the fix-error-declaration-type branch May 27, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The declared types of TokenError are wrong

3 participants