Skip to content

chore: add type for cacheKeyBuilder#546

Merged
simoneb merged 1 commit intonearform:masterfrom
sortxyz:add_cacheKeyBuilder_type
Feb 11, 2025
Merged

chore: add type for cacheKeyBuilder#546
simoneb merged 1 commit intonearform:masterfrom
sortxyz:add_cacheKeyBuilder_type

Conversation

@aheckmann
Copy link
Copy Markdown
Contributor

@aheckmann aheckmann commented Feb 7, 2025

relates to #504 and #503

fixes #547

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 7, 2025
Copy link
Copy Markdown
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aheckmann Can you please write a test to check the newly added type in https://github.com/nearform/fast-jwt/blob/master/test/types.spec.ts?

@aheckmann aheckmann force-pushed the add_cacheKeyBuilder_type branch from 2bf657b to 985409b Compare February 10, 2025 20:05
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 11, 2025
@simoneb simoneb merged commit ffc1b8c into nearform:master Feb 11, 2025
@aheckmann aheckmann deleted the add_cacheKeyBuilder_type branch February 11, 2025 14:47
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing type for cacheKeyBuilder

2 participants