Fix benchmarks with regards to jsonwebtoken performance#535
Fix benchmarks with regards to jsonwebtoken performance#535simoneb merged 10 commits intonearform:masterfrom
Conversation
|
I think you could also update the benchmarks, so we could also close #507 |
|
I had to regenerated the |
|
@Gobd we've done a bit of overhaul on the way we run and capture the benchmark results. When you get a chance, would you mind doing this work on top of what's in master now? I chose to replace cronometro with mitata due to issues with running is cross-platform. |
|
Sure let me work on that |
|
Done! Now you can see jsonwebtoken's performance is much more reasonable so no one panics and thinks they need to switch ASAP. I mean they do need to switch to using the keys correctly ASAP to fix their performance. I have switched to fast-jwt anyways because it was almost no work and is faster. |
Closes #536
The benchmark results in the readme will also need updating but not sure if you wanted me to do that or run them yourselves. The results are exactly like the linked issue suggests, 50x better performance after this change.
I also added HS256 to the benchmarks because why not, and also that's what I use.