Skip to content

Feat/generic signer verifier#529

Merged
simoneb merged 3 commits intonearform:masterfrom
ilteoood:feat/generic-signer-verifier
Dec 16, 2024
Merged

Feat/generic signer verifier#529
simoneb merged 3 commits intonearform:masterfrom
ilteoood:feat/generic-signer-verifier

Conversation

@ilteoood
Copy link
Copy Markdown
Contributor

@ilteoood ilteoood commented Dec 14, 2024

To be reviewed after #528
Closes #225

Copy link
Copy Markdown
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like a breaking change but I'm not terribly familiar with TS's idiosincrasies. Thoughts?

@simoneb simoneb requested a review from Copilot December 15, 2024 14:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@ilteoood
Copy link
Copy Markdown
Contributor Author

@simoneb It shouldn't, since we are providing a default for each generic

@simoneb simoneb requested a review from Copilot December 16, 2024 17:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add generic types to create functions

3 participants