Some resources cleanup#267
Merged
Merged
Conversation
Vogtinator
commented
Dec 6, 2020
Contributor
- Refine Storage in zehn_loader.cpp
- Improve printf use in zehn_loader.cpp
- Drop calchook
- Actually make it safe to use - Add some additional checks - Make it API compatible with std::vector
- Use the msgbox method instead of formatting manually - Use snprintf
- Was mostly a PoC and used quite a few hacks - Not documented anywhere and not regularly tested - Adds a fragile hook in a place which is prone to change - Uses the default allocator, which pulls in exception code (without, ndless_resources.tns goes from 235KiB to 170KiB) - Due to -fno-exceptions, it couldn't handle out of memory situations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.