Fix compatibility with httpx 0.28.0#1
Closed
francoisfreitag wants to merge 1 commit intondhansen:masterfrom
Closed
Fix compatibility with httpx 0.28.0#1francoisfreitag wants to merge 1 commit intondhansen:masterfrom
francoisfreitag wants to merge 1 commit intondhansen:masterfrom
Conversation
Prior to httpx version 0.28.0, request methods were implicitly converted from bytes to strings. In version 0.28.0 that is no longer the case, the method is expected to be an str. A DeprecationWarning has been added so that codebases can adapt during the next release cycle. Co-authored-by: François Freitag <mail@franek.fr>
Author
|
The bytes come from httpcore, and we’re only getting bytes because we’re hooking the mock after httpcore issued the request. So there’s nothing users can do about this warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I included the remarks from the review.