Path unescape the data return in the X-Object-Manifest header#168
Merged
Conversation
This fixes an rclone bug 5180 where openstack/swift returned an url encoded path in the X-Object-Manifest header. This then caused problems when resolving the segments.
ncw
reviewed
Apr 17, 2021
ncw
left a comment
Owner
There was a problem hiding this comment.
Well spotted!
Can you put these in the commit messages
- a link (URL) to the rclone issue
- a link to the Swift docs with the changes
I note that if we are URL decoding X-Object-Manifest then we need to url encode it too which we need to do don't we?
ncw
approved these changes
Oct 6, 2021
ncw
left a comment
Owner
There was a problem hiding this comment.
Apologies for the delay - I'll merge this now - thank you :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an rclone bug 5180 where openstack/swift returned
an url encoded path in the X-Object-Manifest header.
This then caused problems when resolving the segments.