Added remove-empty-groups option#283
Merged
ncabatoff merged 7 commits intoncabatoff:masterfrom Jul 21, 2024
Merged
Conversation
Owner
|
This seems like a reasonable option. If you resolve the conflicts I'm open to merging it. Sorry for the long delay! |
6da7d02 to
64dee46
Compare
Contributor
Author
|
@ncabatoff. Thanks. I've solved the conflicts |
ncabatoff
approved these changes
Jul 21, 2024
Owner
|
Thanks @zviRosenfeldRedis ! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this option is True (default false) we'll remove groups if they have 0 processes (by default we leave the group, assuming processes from that group will be back)
The only real change is at the end of file
proc/grouper.go- where I remove un-found groups if remove-dead-groups is truefixed #282