Skip to content

replace usize with u64#2

Closed
alexanderkjall wants to merge 1 commit intonbari:masterfrom
alexanderkjall:fix-32-bit-architectures
Closed

replace usize with u64#2
alexanderkjall wants to merge 1 commit intonbari:masterfrom
alexanderkjall:fix-32-bit-architectures

Conversation

@alexanderkjall
Copy link

@alexanderkjall alexanderkjall commented Sep 26, 2023

as usize is 32-bit on 32-bit architectures.

Currently the project doesn't build on any 32-bit architecture: https://buildd.debian.org/status/package.php?p=rust-compound-duration

With problems like this:

warning: this arithmetic operation will overflow
   --> src/lib.rs:169:26
    |
169 |     let mut ns = nanos % (DAY * NANOS);
    |                          ^^^^^^^^^^^^^ attempt to compute `86400_usize * 1000000000_usize`, which would overflow
    |
    = note: `#[warn(arithmetic_overflow)]` on by default

It looks to me like this breaks your public api, so I also bumped the major version to 2.

@nc7s nc7s mentioned this pull request Sep 26, 2023
Closed
@alexanderkjall alexanderkjall mentioned this pull request Oct 24, 2023
Merged
@nbari nbari deleted the branch nbari:master November 5, 2025 05:49
@nbari nbari closed this Nov 5, 2025
@nbari
Copy link
Owner

nbari commented Nov 5, 2025

Hi @alexanderkjall, sorry for the huge delay. Many thanks for the PR, already applied (looks like it was closed because I moved from branch master to main and got closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexanderkjall @nbari