Fix tests to make them compatible with non-english GPG installations#68
Merged
Conversation
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 4 | 0 | 0.14s | |
| ✅ COPYPASTE | jscpd | yes | no | 1.36s | |
| ✅ CREDENTIALS | secretlint | yes | no | 0.78s | |
| ✅ GIT | git_diff | yes | no | 0.01s | |
| ✅ JAVASCRIPT | standard | 1 | 0 | 0 | 1.12s |
| ✅ JSON | eslint-plugin-jsonc | 7 | 0 | 0 | 0.77s |
| ✅ JSON | jsonlint | 7 | 0 | 1.55s | |
| ✅ JSON | prettier | 7 | 1 | 0 | 1.06s |
| ✅ JSON | v8r | 7 | 0 | 5.97s | |
| markdownlint | 2 | 0 | 1 | 0.31s | |
| ✅ MARKDOWN | markdown-link-check | 2 | 0 | 4.96s | |
| ✅ MARKDOWN | markdown-table-formatter | 2 | 2 | 0 | 0.23s |
| ✅ SPELL | cspell | 80 | 0 | 2.84s | |
| ✅ SPELL | misspell | 80 | 2 | 0 | 0.13s |
| ✅ TYPESCRIPT | eslint | 54 | 2 | 0 | 12.35s |
| ✅ YAML | prettier | 7 | 0 | 0 | 1.79s |
| ✅ YAML | v8r | 7 | 0 | 7.34s | |
| ✅ YAML | yamllint | 7 | 0 | 0.25s |
See errors details in artifact MegaLinter reports on CI Job page
josecelano
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the tests referenced in #66 compatible with non-english GPG installations.
To do so, it replaces the full expected string with a RegExp in which the words "gpg:", RSA and the fingerprint are checked.
Although we cannot assure that it creates false-positive tests (maybe considering valid a string reporting an error with the RSA key), I think it is very unlikely, but the possibility of the user having a non-english GPG installation is very high.