Fix failing integration test on forks#240
Merged
josecelano merged 1 commit intoJun 6, 2022
Merged
Conversation
6229c86 to
3b2bb25
Compare
Member
Author
|
It's not working yet becuase I have to change this line: To use the ouput from the "Import test GPG key" or read from the temp file In fact, we do not need to import the key only read it from the fixtures folder. |
b05ac2c to
42b7d29
Compare
42b7d29 to
90b5009
Compare
Member
Author
|
I had to add a line break after the GPG private key header: 94543d4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a pretty annoying bug that makes fail all
testworkflows on pull request events from a forked repository.As we still need Git Queue action to sign commits I have just fixed it by importing the GPG key we are using for testing instead of importing it from secrets. Anyway, that's the right way to do it.
We agree on removing the signing option from the Git Queue but in this case, the Git Queue is not signing commits. I'm only testing that Git Queue does not interfere with Git global signing configuration.