Issue #24: Json Metadata as Commit Body#118
Merged
yeraydavidrodriguez merged 2 commits intoApr 18, 2022
Merged
Conversation
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 5 | 0 | 0.2s | |
| ✅ COPYPASTE | jscpd | yes | no | 1.91s | |
| ✅ CREDENTIALS | secretlint | yes | no | 1.04s | |
| ✅ GIT | git_diff | yes | no | 0.02s | |
| ✅ JAVASCRIPT | standard | 1 | 0 | 0 | 1.5s |
| ✅ JSON | eslint-plugin-jsonc | 7 | 0 | 0 | 1.01s |
| ✅ JSON | jsonlint | 7 | 0 | 1.98s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0.72s |
| ✅ JSON | v8r | 7 | 0 | 7.84s | |
| markdownlint | 2 | 0 | 1 | 0.4s | |
| ✅ MARKDOWN | markdown-link-check | 2 | 0 | 5.02s | |
| ✅ MARKDOWN | markdown-table-formatter | 2 | 0 | 0 | 0.34s |
| ✅ SPELL | cspell | 81 | 0 | 4.36s | |
| ✅ SPELL | misspell | 81 | 0 | 0 | 0.19s |
| ✅ TYPESCRIPT | eslint | 54 | 0 | 0 | 14.62s |
| ✅ YAML | prettier | 8 | 0 | 0 | 1.09s |
| ✅ YAML | v8r | 8 | 0 | 10.43s | |
| ✅ YAML | yamllint | 8 | 0 | 0.3s |
See errors details in artifact MegaLinter reports on CI Job page
yeraydavidrodriguez
approved these changes
Apr 5, 2022
yeraydavidrodriguez
left a comment
Collaborator
There was a problem hiding this comment.
Checked that the changes are the same as in the non-squashed branch.
Thank you, @da2ce7 . I did a squash of the last commits in the other branch, but I'm afraid I made some mistakes (I'm not extremely good at solving [code] conflicts), had to force-push a few times and the branch got slightly messy.
This new branch is very much cleaner.
josecelano
requested changes
Apr 5, 2022
josecelano
requested changes
Apr 12, 2022
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
josecelano
approved these changes
Apr 13, 2022
47a8399 to
ff1e70c
Compare
Contributor
Author
|
@yeraydavidrodriguez rebased 👍 |
Collaborator
Thanks @da2ce7 ! |
ff1e70c to
3da3fd4
Compare
Create Schema Enforced Json Message the Commit Body. Includes: - Namespace. - Version. - Custom Payload. May be safely expanded in future by expanding the schema and issuing a new version. (Implements Issue: #24)
3da3fd4 to
5e497bc
Compare
Contributor
Author
|
@yeraydavidrodriguez rebased and squashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Json Metadata as Commit Body
Create Schema Enforced Json Message the Commit Body.
Includes:
May be safely expanded in future by expanding the schema and issuing a new version.
closes #24