Merged
Conversation
Collaborator
alexanderbates
commented
Aug 6, 2019
- read flycircuit neurons and get flycircuit neuron IDs
- updates to README
- Not sure how to solve error thrown by Rmd Check
Collaborator
|
(just a note that I still have work to do on this branch ...) |
GJ mods: * move registrations to a folder included in package * inst/extdata (perhaps against convention) is ignored during package build because it is in .Rbuildignore. This was likely the reason for the issue with the location of registration files earlier * remove duplicate registration file * had both gzipped and plain text version
* correct path
* was missing some ids and making extra page requests * dontrun example – it's very long if pkgdown tries to run it
* and details of v1.0 v 1.2 ids
* don't run long running example
* this is the pattern in the rest of the package s
Collaborator
|
NB I rebased to avoid the addition of a duplicate copy of one of the warping registrations. |
Collaborator
|
Also note additional fixes in 7b59db6 for |
Collaborator
|
and that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.