Add getDisplayMedia and PipeWire support by johan12345 · Pull Request #1477 · nativefier/nativefier

johan12345 · 2022-11-02T18:36:24Z

I'm picking up @RickStanley's abandoned PR #1321 again to add screensharing support (fixes #927), with the following additional changes:

In newer Electron versions, desktopCapturer.getSources must be called from the main process, so I solved this with an IPC call.
Importing from ./helpers/helpers in 'preload.ts' does not work, as was mentioned by @DimICE in Add getDisplayMedia and PipeWire support #1321 (comment). I'm not very familiar with TypeScript or Electron, so not sure why that is and how it could be solved - for now I just copied the referenced isWayland function to preload.ts.
Add a screensharing test to the manual test script, as requested by @ronjouch in Add getDisplayMedia and PipeWire support #1321 (comment)

As far as I understood from the discussion in #1321, the last point was basically the only thing that was missing to get this merged, correct?

This prevents the scenario where the promise never finishes.

johan12345 · 2022-11-03T08:41:19Z

I can confirm that this works with both Windows and Linux (Xorg), haven't tested Wayland.

ronjouch

@johan12345 thanks! Hmmmmmm, looking at #1321 & comments, I see two remaining things to address:

✅ A smoke test
🔲 The last paragraph of #1321 (comment) , a "dialog element/browserwindow for screen share picker" . I'm okay to merge your PR without it (and I'd rather, actually, 2 small atomic PRs are better than one larger PR), but I just wanted to be sure it was fine with the original author (or you, now that you're pushing this)

ronjouch · 2022-11-07T22:43:44Z

+
+# ------------------------------------------------------------------------------
+
+printf '\n***** SMOKE TEST 4: Setting up test and building app... *****\n'


👍👍👍

johan12345 · 2022-11-08T18:15:49Z

Thanks @ronjouch! Yes, the comments that you added for the copy-pasted isWayland function are a good idea.

Yeah, I agree an improved UI using a dialog for the screen share picker could be tackled in a separate issue & PR. For me that would be fine (and I'm not sure how much time I would have to work on that myself in the short-term, so probably better to get this highly-requested feature merged sooner than later 🙂), and I think @RickStanley agreed to that as well in his original PR #1321:

As for dialog element/browserwindow for screen share picker: I think the latter is the better option, on the long run, thinking about support and web standards of dialog, maybe it's not ready yet (my opinion). And create an issue as an enhancement.

ronjouch · 2022-11-08T18:36:58Z

Okay. Will re-review and merge soon. Thx.

EDIT I no longer maintain Nativefier and no longer have merge/write permissions. I won't be merging this, but another maintainer might.

TylerLaBree · 2022-12-07T23:17:48Z

@jiahaog Are there any plans to merge this in the future? It looks to me like you're the only maintainer on this project.

Apologies if this isn't the right place to ask.

Lythenas · 2023-03-13T17:17:33Z

I tested this with MS Teams on Wayland (Ubuntu 22.04) and it works basically the same as Teams in Chromium.

Would be nice if this can be merged (I spent way to much time searching around until I found this PR...).

LukeAI · 2023-03-22T23:37:19Z

I would very much like to be able to run MS Teams with screen sharing - if it's just silence from the maintainers maybe a fork would be an idea?

TheCleric · 2023-03-23T00:19:26Z

Sorry for the silence. I'll take a look as soon as I can at this and see about getting it merged in.

As well, I'd be curious to know for those waiting for this: is there an advantage of using Teams in this way (with Nativefier) over using it via a PWA app from the browser? I know redistribution would be one, but not sure if that was anyone's actual goal here.

LukeAI · 2023-03-23T00:25:02Z

Thanks @TheCleric - I just like having Teams as it's own app separate from the browser. Independently launchable, separate window, won't go away when I bulk close all my tabs. Not a big deal but helps my workflow.

TheCleric · 2023-03-23T00:27:17Z

+export function isWayland(): boolean {
+  return (
+    isLinux() &&
+    (Boolean(process.env.WAYLAND_DISPLAY) ||


For the record Boolean or boolean on a string only returns its truthiness (i.e., is it not blank, null, nor undefined).

> Boolean('true') true > Boolean('false') true

We have written a parseBoolean function in src/utils/parseUtils.ts that should probably be copy and pasted here for use in the app.

I think in this case Boolean is okay, as the WAYLAND_DISPLAY environment variable does not contain a "true"/"false" value, but rather the name of a display. So what we want to check here is just whether it has been set to some value (not null or empty) or not.

Ahh, thanks for the clarification.

TheCleric · 2023-03-23T00:31:25Z

+function isWayland(): boolean {
+  return (
+    isLinux() &&
+    (Boolean(process.env.WAYLAND_DISPLAY) ||


See above comment about parseBoolean

toffereins-stratusgroup · 2023-03-23T01:27:27Z

Sorry for the silence. I'll take a look as soon as I can at this and see about getting it merged in.

As well, I'd be curious to know for those waiting for this: is there an advantage of using Teams in this way (with Nativefier) over using it via a PWA app from the browser? I know redistribution would be one, but not sure if that was anyone's actual goal here.

Just chiming in here, to backup @LukeAI. I too prefer Teams in a controlled, independently launchable sandbox away from my browser. I do this for Outlook as well, among others.

johan12345 · 2023-03-23T09:23:25Z

Yep, same usecase for me, with the additional reason that I need two separate instances of Teams to sign in to different accounts/organizations. That is not possible with the PWA as far as I know, at least not on Linux.

TheCleric · 2023-03-23T15:49:49Z

Don't use Teams, but verified this works great with Zoom. Thanks for the contribution. Will get it merged in, and try to get a release soon. This will be my first release (previously handled by ronjouch) so please be patient. May take a little while to make sure the permissions are setup and I don't mess it up. 😆

Eugeniusz-Gienek · 2023-03-23T16:33:39Z

What about Mac? I hope this will allow screen sharing in teams on mac... Won't it?

johan12345 · 2023-03-23T17:03:36Z

In principle it should, but I do not have a Mac to test. The original author in #1321 also said it was not tested on Mac.

niccolomineo · 2023-03-23T18:08:03Z

In principle it should, but I do not have a Mac to test. The original author in #1321 also said it was not tested on Mac.

I am willing to test this with Google Meet as soon as a new release is put out.

TheCleric · 2023-03-23T20:33:48Z

My test with Zoom was on a Mac, so I anticipate it should work.

niccolomineo · 2023-03-23T22:33:00Z

Looking forward to this being officially released. Any ETA for this?

LukeAI · 2023-04-13T14:22:22Z

@TheCleric any ETA on when we can expect this in npm? Anything I can do to help?

TheCleric · 2023-04-13T14:54:07Z

Apologies. This was released and is in the latest version.

niccolomineo · 2023-04-13T15:09:53Z

Apologies. This was released and is in the latest version.

It doesn't work with Google Meet, though. Any idea why?

Rick Stanley and others added 11 commits November 2, 2022 17:59

Add getDisplayMedia and PipeWire support

59a4738

Remove unnecessary spawn

745a13a

Add additional test for Wayland

1df57be

Move close button to outter scope

ad55f50

fix(linter): eslint errors

71e765c

feat: respect some user's colors

5080332

fix(lint): fix linter errors

5c5d7af

refactor(lint): remove unused variables

d7a8103

fix: add rejection for user interaction

451e2ac

This prevents the scenario where the promise never finishes.

Fix issues with getDisplayMedia & latest Electron

a9b70ea

add screensharing to manual test script

0f37d40

ronjouch reviewed Nov 7, 2022

View reviewed changes

Apply suggestions from code review

ffae28d

TheCleric reviewed Mar 23, 2023

View reviewed changes

TheCleric merged commit 79009e8 into nativefier:master Mar 23, 2023

mikart143 mentioned this pull request May 31, 2023

Google Meet won't let sharing screen #1524

Closed

5 tasks


		# ------------------------------------------------------------------------------

		printf '\n*** SMOKE TEST 4: Setting up test and building app... ***\n'

Uh oh!

Conversation

johan12345 commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johan12345 commented Nov 3, 2022

Uh oh!

ronjouch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ronjouch Nov 7, 2022

Choose a reason for hiding this comment

Uh oh!

johan12345 commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronjouch commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TylerLaBree commented Dec 7, 2022

Uh oh!

Lythenas commented Mar 13, 2023

Uh oh!

LukeAI commented Mar 22, 2023

Uh oh!

TheCleric commented Mar 23, 2023

Uh oh!

LukeAI commented Mar 23, 2023

Uh oh!

TheCleric Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

johan12345 Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

TheCleric Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

TheCleric Mar 23, 2023

Choose a reason for hiding this comment

Uh oh!

toffereins-stratusgroup commented Mar 23, 2023

Uh oh!

johan12345 commented Mar 23, 2023

Uh oh!

TheCleric commented Mar 23, 2023

Uh oh!

Eugeniusz-Gienek commented Mar 23, 2023

Uh oh!

johan12345 commented Mar 23, 2023

Uh oh!

niccolomineo commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheCleric commented Mar 23, 2023

Uh oh!

niccolomineo commented Mar 23, 2023

Uh oh!

LukeAI commented Apr 13, 2023

Uh oh!

TheCleric commented Apr 13, 2023

Uh oh!

niccolomineo commented Apr 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

johan12345 commented Nov 2, 2022 •

edited

Loading

johan12345 commented Nov 8, 2022 •

edited

Loading

ronjouch commented Nov 8, 2022 •

edited

Loading

niccolomineo commented Mar 23, 2023 •

edited

Loading