fix: make default-local-pref usable#152
Merged
natesales merged 1 commit intonatesales:mainfrom Jan 23, 2023
yoursunny:defaultlocalpref
Merged
fix: make default-local-pref usable#152natesales merged 1 commit intonatesales:mainfrom yoursunny:defaultlocalpref
natesales merged 1 commit intonatesales:mainfrom
yoursunny:defaultlocalpref
Conversation
natesales
requested changes
Jan 22, 2023
Owner
natesales
left a comment
There was a problem hiding this comment.
Thanks for the fix! Just one minor thing to update here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a logical error in
process.Load, any peer withdefault-local-prefproperty set is resulting in error:This above error occurs even if
optimize-inboundis not set.This patch fixes this logical error and makes
default-local-prefusable again.