Skip to content

Bugfix: Copy manual*.conf to cache dir#133

Merged
natesales merged 2 commits intonatesales:mainfrom
l27001:manual_fix
Oct 7, 2022
Merged

Bugfix: Copy manual*.conf to cache dir#133
natesales merged 2 commits intonatesales:mainfrom
l27001:manual_fix

Conversation

@l27001
Copy link
Copy Markdown
Contributor

@l27001 l27001 commented Sep 3, 2022

Hello,
I have created a manual-communities.conf file in the BIRD directory with function like:

function action_communities() {
  if ((206016,0,999) ~ bgp_large_community) then _reject("By action community");
}

And then tried to use this function in pre-export attribute. But got an error when executing pathvector generate:

INFO[0000] Starting Pathvector devel                    
FATA[0000] BIRD: BIRD validation error:
        export filter {
            action_communities();
            ^ syntax error, unexpected CF_SYM_UNDEFINED
            remove_private_asns();

If I add this function directly to config ASxxx_NAME_v6.conf and run birdc configure check I got answer Configuration OK

After some investigating I found that pathvector creates cache dir and check config files from this dir BUT it don't include/copy manual*.conf files from original BIRD directory. Therefore, pathvector considers that the function from the manual-communities.conf file does not exist
So, I wrote this patch which copy all manual*.conf from BIRD directory to cache directory and this solve the problem.

@natesales
Copy link
Copy Markdown
Owner

Sorry for the delay here! Can you bring 34ad154 in so we can rerun the tests?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 35.94% // Head: 35.94% // No change to project coverage 👍

Coverage data is based on head (34ad154) compared to base (05f7142).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 34ad154 differs from pull request most recent head 3b14e6e. Consider uploading reports for the commit 3b14e6e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   35.94%   35.94%           
=======================================
  Files          17       17           
  Lines        1138     1138           
=======================================
  Hits          409      409           
  Misses        623      623           
  Partials      106      106           
Impacted Files Coverage Δ
pkg/process/process.go 33.33% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@natesales natesales merged commit 7be2cf6 into natesales:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants