Bugfix: Copy manual*.conf to cache dir#133
Merged
natesales merged 2 commits intonatesales:mainfrom Oct 7, 2022
Merged
Conversation
Owner
|
Sorry for the delay here! Can you bring 34ad154 in so we can rerun the tests? |
Codecov ReportBase: 35.94% // Head: 35.94% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 35.94% 35.94%
=======================================
Files 17 17
Lines 1138 1138
=======================================
Hits 409 409
Misses 623 623
Partials 106 106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have created a
manual-communities.conffile in the BIRD directory with function like:And then tried to use this function in
pre-exportattribute. But got an error when executingpathvector generate:If I add this function directly to config
ASxxx_NAME_v6.confand runbirdc configure checkI got answerConfiguration OKAfter some investigating I found that pathvector creates cache dir and check config files from this dir BUT it don't include/copy
manual*.conffiles from original BIRD directory. Therefore, pathvector considers that the function from themanual-communities.conffile does not existSo, I wrote this patch which copy all
manual*.conffrom BIRD directory to cache directory and this solve the problem.