Add missing provider role (BGP RFC 9234)

L8X · web-flow · commit 99ea7d87ba65 · 2023-04-04T09:58:48.000+01:00
As per BIRD 2.0 documentation: Possible role-name values are: provider, rs_server, rs_client, customer and peer. Default: No local role assigned. Source: https://bird.network.cz/?get_doc&v=20&f=bird-6.html#ss6.3
diff --git a/pkg/process/process.go b/pkg/process/process.go
@@ -290,8 +290,8 @@ func Load(configBlob []byte) (*config.Config, error) {
 		// Validate RFC 9234 BGP role
 		if peerData.Role != nil {
 			peerData.Role = util.Ptr(strings.ReplaceAll(*peerData.Role, "-", "_"))
-			if *peerData.Role != "rs_server" && *peerData.Role != "rs_client" && *peerData.Role != "customer" && *peerData.Role != "peer" {
-				return nil, fmt.Errorf("[%s] Invalid BGP role: %s (must be one of rs-server, rs-client, customer, peer)", *peerData.Role, peerName)
+			if *peerData.Role != "provider" && peerData.Role != "rs_server" && *peerData.Role != "rs_client" && *peerData.Role != "customer" && *peerData.Role != "peer" {
+				return nil, fmt.Errorf("[%s] Invalid BGP role: %s (must be one of provider, rs-server, rs-client, customer, peer)", *peerData.Role, peerName)
 			}
 		}
 		requireRoles := peerData.RequireRoles != nil && *peerData.RequireRoles

Original file line number	Diff line number	Diff line change
`@@ -290,8 +290,8 @@ func Load(configBlob []byte) (*config.Config, error) {`
`290`	`290`	`// Validate RFC 9234 BGP role`
`291`	`291`	`if peerData.Role != nil {`
`292`	`292`	`peerData.Role = util.Ptr(strings.ReplaceAll(*peerData.Role, "-", "_"))`
`293`		`- if peerData.Role != "rs_server" && peerData.Role != "rs_client" && peerData.Role != "customer" && peerData.Role != "peer" {`
`294`		`- return nil, fmt.Errorf("[%s] Invalid BGP role: %s (must be one of rs-server, rs-client, customer, peer)", *peerData.Role, peerName)`
	`293`	`+ if peerData.Role != "provider" && peerData.Role != "rs_server" && peerData.Role != "rs_client" && peerData.Role != "customer" && peerData.Role != "peer" {`
	`294`	`+ return nil, fmt.Errorf("[%s] Invalid BGP role: %s (must be one of provider, rs-server, rs-client, customer, peer)", *peerData.Role, peerName)`
`295`	`295`	`}`
`296`	`296`	`}`
`297`	`297`	`requireRoles := peerData.RequireRoles != nil && *peerData.RequireRoles`