Fix #123: Add validation for invalid temporal keys like 'end'#125
Merged
flamingbear merged 2 commits intoFeb 16, 2026
Merged
Conversation
chris-durbin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR - just one comment about simplifying the error message, otherwise looks good.
| 'end': dt.datetime(2019, 12, 30) | ||
| }, | ||
| ('Temporal range keys must be either "start" or "stop". ' | ||
| 'Note: Use "stop" instead of "end" (common mistake).') |
Contributor
There was a problem hiding this comment.
Can you drop the note about "end" which might be confusing some users?
'Temporal range keys must be either "start" or "stop" makes it clear to users what values are allowed.
flamingbear
reviewed
Feb 16, 2026
flamingbear
left a comment
Member
There was a problem hiding this comment.
Thanks, same comments as Chris.
Comment on lines
+427
to
+428
| ('Temporal range keys must be either "start" or "stop". ' | ||
| 'Note: Use "stop" instead of "end" (common mistake).')), |
Member
There was a problem hiding this comment.
Suggested change
| ('Temporal range keys must be either "start" or "stop". ' | |
| 'Note: Use "stop" instead of "end" (common mistake).')), | |
| ('Temporal range keys must be either "start" or "stop".')), |
Like @chris-durbin said, this is less confusing I think.
Comment on lines
+214
to
+215
| ('Temporal range keys must be either "start" or "stop". ' | ||
| 'Note: Use "stop" instead of "end" (common mistake).') |
Member
There was a problem hiding this comment.
Suggested change
| ('Temporal range keys must be either "start" or "stop". ' | |
| 'Note: Use "stop" instead of "end" (common mistake).') | |
| ('Temporal range keys must be either "start" or "stop".') |
Contributor
Author
|
@flamingbear @chris-durbin As suggested I have improved the message. let me know if it looks good now. Thank you |
flamingbear
approved these changes
Feb 16, 2026
flamingbear
left a comment
Member
There was a problem hiding this comment.
Thanks for the update @sonikaarora 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
GitHub Issue #123
Description
Request.is_valid()was incorrectly passing when users accidentally used thekey
'end'instead of'stop'in temporal range dictionaries. This causedsilent failures where:
and end required"
Solution
Added validation to the
Requestclass temporal validations that:Changes
temporal_validationslistPR Acceptance Checklist