Jira Issue ID

HARMONY-2168

Fixes #116

Description

When constructing a Harmony Client the ENVIRONMENT env var was incorrectly overriding the desired harmony environment. This PR changes the code to ignore the ENVIRONMENT env var so that the behavior is to use the environment passed into the client constructor or default to production if no environment is passed in.

Local Test Steps

This should fail on the main branch but pass in this branch.

import os

os.environ['ENVIRONMENT'] = 'foo'
harmony_client = Client() 

assert harmony_client.config.environment == Environment.PROD
assert harmony_client.config.harmony_hostname == 'harmony.earthdata.nasa.gov'

You can test other combinations like harmony_client = Client(should_validate_auth=False, env=Environment.UAT) as well.

PR Acceptance Checklist

• Acceptance criteria met
• Tests added/updated (if needed) and passing
• Documentation updated (if needed)