HARMONY-1997: As a harmony-py user I would like to see a warning message when a job results in no data.#108
Merged
Merged
Conversation
…age when a job results in no data.
chris-durbin
approved these changes
Mar 4, 2025
chris-durbin
left a comment
Contributor
There was a problem hiding this comment.
Tested successfully.
indiejames
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1997
Description
Updated harmony-py to report error when there is no files to download for failed or warning requests during
client.download_allinvocation.Local Test Steps
Since we have to use customized (fake) service image to get requests into warning state, it doesn't make sense to add a notebook to demonstrate this behavior. Also the current failed request notebook is returning success probably due to recent configuration changes which we will have to fix as a separate issue (HARMONY-2034).
Here is a notebook snippet to test the error reporting for warning request. I will restore the faked service-example image in UAT once this PR is merged.
PR Acceptance Checklist