Skip to content

HARMONY-1900: As a harmony-py user, I want to be able to query for jobs using one or more labels#105

Merged
ygliuvt merged 5 commits into
mainfrom
harmony-1900
Feb 12, 2025
Merged

HARMONY-1900: As a harmony-py user, I want to be able to query for jobs using one or more labels#105
ygliuvt merged 5 commits into
mainfrom
harmony-1900

Conversation

@ygliuvt

@ygliuvt ygliuvt commented Feb 12, 2025

Copy link
Copy Markdown
Member

Jira Issue ID

HARMONY-1900

Description

Add capability to query for jobs using one or more labels in harmony-py.
Refactored harmony.harmony module into harmony.request and harmony.client.

Local Test Steps

Run examples/job_label.ipynb for job searching example.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@indiejames indiejames left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

Comment thread examples/job_label.ipynb

@chris-durbin chris-durbin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw one cell in the notebook is code, but should be markdown (#### Search jobs by labels).

I think it would be good for the search by labels example in the notebook to show that it ORs the labels. Right now it is not clear because every job that is returned has both the foo and bar labels.

@ygliuvt ygliuvt merged commit 6222df2 into main Feb 12, 2025
@ygliuvt ygliuvt deleted the harmony-1900 branch February 12, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants