HARMONY-1898: As harmony-py user, I want to be able add one or more labels to one or more of my jobs#102
Merged
Merged
Conversation
6c5baa8 to
796908b
Compare
796908b to
24037ec
Compare
chris-durbin
approved these changes
Feb 6, 2025
chris-durbin
left a comment
Contributor
There was a problem hiding this comment.
Tested successfully, I like the refactor to BaseRequest. I also verified we have a separate ticket for removing labels from jobs.
indiejames
reviewed
Feb 6, 2025
indiejames
left a comment
Contributor
There was a problem hiding this comment.
See my comment about the http_method parameter.
indiejames
approved these changes
Feb 6, 2025
indiejames
left a comment
Contributor
There was a problem hiding this comment.
Tested code changes - looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1898
Description
As harmony-py user, I want to be able add one or more labels to one or more of my jobs
Local Test Steps
Run labels notebook and verify adding labels to jobs work as expected.
Verify readthedocs documentation is ok.
PR Acceptance Checklist