HARMONY-1993: Allow users to set custom labels for harmony requests.#101
Merged
Conversation
ygliuvt
approved these changes
Jan 29, 2025
vinnyinverso
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1993
Description
Allows users to set custom labels on harmony requests.
Note that I also upgraded some libraries to eliminate several warnings.
Local Test Steps
Bring up one of the notebooks like
tutorial.ipynb. Modify a request to set labels by addinglabels=['foo', 'bar']to the request constructor. Verify that the harmony request that gets created includes the labels 'foo', 'bar', and 'harmony-py'.Repeat the test after setting the environment variable
EXCLUDE_DEFAULT_LABEL=true. Verify that the labels 'foo' and 'bar' are included in the request, but not 'harmony-py'.Verify that submitting a request without any labels field also works.
PR Acceptance Checklist