Harmony 1936: Add default job label to harmony-py jobs#100
Merged
Conversation
vinnyinverso
approved these changes
Jan 22, 2025
Contributor
|
My only thought is that I wish there were a more centralized place to surface this information to the user, maybe via the readthedocs? |
Contributor
Author
Totally agree - was really frustrated by this. Didn't try to update the readthedocs stuff, because it looks that that is totally focused on the API, which is not really what this PR is about. |
chris-durbin
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1936
Description
This PR adds a default label of 'harmony-py' to jobs created with this library. It can be disabled by setting the environment variable
EXCLUDE_DEFAULT_LABELto "true".Local Test Steps
EXCLUDE_DEFAULT_LABELenv var to "true"PR Acceptance Checklist