Skip to content

Format all top-level source folders#4134

Merged
thomas-bc merged 1 commit intonasa:develfrom
thomas-bc:format-rodeo
Sep 10, 2025
Merged

Format all top-level source folders#4134
thomas-bc merged 1 commit intonasa:develfrom
thomas-bc:format-rodeo

Conversation

@thomas-bc
Copy link
Collaborator

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)
Generative AI was used in this contribution (y/n)

Change Description

Fixes #3996

Adds last couple top-level folders formatting and CI checks.

NOTE: I did not add STest as it is already self-consistent.... but maybe we should. To be discussed.

Checksum(const U32 value);

//! Copy a Checksum object.
Checksum(const Checksum& original);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning

Single-parameter constructors should be marked explicit.
struct RandomizeRule : public STest::Rule<MockTypes::CircularState> {
// Constructor
RandomizeRule(const char* const name);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
struct SerializeOkRule : public STest::Rule<MockTypes::CircularState> {
// Constructor
SerializeOkRule(const char* const name);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
struct SerializeOverflowRule : public STest::Rule<MockTypes::CircularState> {
// Constructor
SerializeOverflowRule(const char* const name);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
struct PeekOkRule : public STest::Rule<MockTypes::CircularState> {
// Constructor
PeekOkRule(const char* const name);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
struct PeekBadRule : public STest::Rule<MockTypes::CircularState> {
// Constructor
PeekBadRule(const char* const name);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
struct RotateOkRule : public STest::Rule<MockTypes::CircularState> {
// Constructor
RotateOkRule(const char* const name);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
struct RotateBadRule : public STest::Rule<MockTypes::CircularState> {
// Constructor
RotateBadRule(const char* const name);

Check warning

Code scanning / CppCheck

Single-parameter constructors should be marked explicit. Warning test

Single-parameter constructors should be marked explicit.
// set new rate, replenish quickly
while (bucket.trigger(Fw::Time(0,0)));
while (bucket.trigger(Fw::Time(0, 0)))
;

Check warning

Code scanning / CppCheck

Line contains only semicolon. If this should be an empty statement, use {} instead. Warning test

Line contains only semicolon. If this should be an empty statement, use {} instead.
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@thomas-bc thomas-bc merged commit ba65039 into nasa:devel Sep 10, 2025
51 of 52 checks passed
@thomas-bc thomas-bc deleted the format-rodeo branch September 10, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Formatting Round-Up Rodeo

2 participants