Conversation
| virtual ~ActiveRateGroupTester(); | ||
| class ActiveRateGroupTester : public ActiveRateGroupGTestBase { | ||
| public: | ||
| ActiveRateGroupTester(Svc::ActiveRateGroup& inst); |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning test
| public: | ||
| //! Construct object BufferLoggerTester | ||
| //! | ||
| BufferLoggerTester(bool doInitLog = true); |
Check warning
Code scanning / CppCheck
Constructors callable with one argument should be marked explicit. Warning test
| // first buffer should point at location just past buffer structs | ||
| U8* mem = reinterpret_cast<U8*>(alloc.getMem()) + | ||
| this->component.m_numStructs * sizeof(Svc::BufferManagerComponentImpl::AllocatedBuffer); | ||
| ; |
Check warning
Code scanning / CppCheck
Line contains only semicolon. If this should be an empty statement, use {} instead. Warning test
| }; | ||
| class CommandDispatcherTester : public CommandDispatcherGTestBase { | ||
| public: | ||
| CommandDispatcherTester(Svc::CommandDispatcherImpl& inst); |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning test
| ComLoggerTester(const char* const compName); | ||
|
|
||
| // This constructor will construct comLogger with its | ||
| // standard constructor |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning test
| { } | ||
| public: | ||
| //! Construct a PacketsReceived object | ||
| PacketsReceived(FileUplink* const fileUplink) : m_received_packet_count(0), m_fileUplink(fileUplink) {} |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning
| public: | ||
| public: | ||
| //! Construct a Warnings object | ||
| Warnings(FileUplink* const fileUplink) : m_warning_count(0), m_fileUplink(fileUplink) {} |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning
| virtual ~PassiveRateGroupTester(); | ||
| class PassiveRateGroupTester : public PassiveRateGroupGTestBase { | ||
| public: | ||
| PassiveRateGroupTester(Svc::PassiveRateGroup& inst); |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning test
| Os::File::Status m_testWriteStatus; | ||
| class PrmDbTester : public PrmDbGTestBase { | ||
| public: | ||
| PrmDbTester(Svc::PrmDbImpl& inst); |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning test
| virtual ~RateGroupDriverImplTester(); | ||
| class RateGroupDriverImplTester : public RateGroupDriverGTestBase { | ||
| public: | ||
| RateGroupDriverImplTester(Svc::RateGroupDriver& inst); |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning test
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| m_overrunThrottle(0), | ||
| m_cycleSlips(0) {} | ||
|
|
||
| void ActiveRateGroup::configure(U32 contexts[], FwIndexType numContexts) { |
Check notice
Code scanning / CodeQL
No raw arrays in interfaces Note
|
|
||
| DpCatalog ::~DpCatalog() {} | ||
|
|
||
| void DpCatalog::configure(Fw::FileNameString directories[DP_MAX_DIRECTORIES], |
Check notice
Code scanning / CodeQL
No raw arrays in interfaces Note
Change Description
Towards #1984
Format Svc/ module (except FpySequencer which is WIP) and add to CI