Skip to content

[ROSES] Update CMake Library integration guide based on student review#3804

Merged
thomas-bc merged 1 commit intonasa:develfrom
thomas-bc:roses/external-library-student-review
Jun 26, 2025
Merged

[ROSES] Update CMake Library integration guide based on student review#3804
thomas-bc merged 1 commit intonasa:develfrom
thomas-bc:roses/external-library-student-review

Conversation

@thomas-bc
Copy link
Collaborator

@thomas-bc thomas-bc commented Jun 25, 2025

Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Fix #3577

Close out #3577 by updating guide based on review recommendations

@thomas-bc thomas-bc requested a review from gorsheep June 25, 2025 23:13
@thomas-bc thomas-bc moved this from CCB to In Review in F´ ROSES F.7 OSTFL Jun 25, 2025
@thomas-bc thomas-bc added the ROSES Work funded by the ROSES proposal - see Discussions #3041 label Jun 25, 2025
@thomas-bc thomas-bc merged commit 628672a into nasa:devel Jun 26, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in F´ ROSES F.7 OSTFL Jun 26, 2025
@thomas-bc thomas-bc deleted the roses/external-library-student-review branch June 26, 2025 20:21
@gorsheep
Copy link

gorsheep commented Jul 7, 2025

The updated documentation addresses nearly all of the previously provided feedback. One point that may still benefit from clarification is the use of the term “module.” It remains unclear whether this is intended as a CMake-specific term or if it refers to a particular F′ concept. For instance, in the phrase “Any component or module that depends on…” the term “component” is clearly defined within the F′ framework, but the distinction between “module” and “component” is not explained. Providing a brief clarification of what constitutes a “module” in this context and how it relates to or differs from a “component” would help improve reader understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ROSES Work funded by the ROSES proposal - see Discussions #3041

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ROSES - Student review of Third-Party Library integration

3 participants