Updates for Svc/BufferAccumulator corresponding to UT cmake update for protected/private#3786
Merged
LeStarch merged 2 commits intonasa:develfrom Jun 25, 2025
Merged
Updates for Svc/BufferAccumulator corresponding to UT cmake update for protected/private#3786LeStarch merged 2 commits intonasa:develfrom
LeStarch merged 2 commits intonasa:develfrom
Conversation
…r protected/private
LeStarch
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
I locally updated
fprime/cmake/settings.cmaketo change-DPROTECTED=protected -DPRIVATE=private. This causes additional build errors beyond all our updates in manual code for PRIVATE->private and PROTECTED->protected due to auto-coded files which use PRIVATE, PROTECTED. This set of changes is associated with fixingSvc/BufferAccumulatorTesterso that the UTs in this directory can build and pass.Approach in this case was:
Added a helper dispatchOne to (base) BufferAccumulatorTester which is an existing friend in the autocoded file
Rationale
#3446
Future Work
Note that this PR does does not include the update to
fprime/cmake/settings.cmakeitself