Updates for Svc/PrmDb corresponding to UT cmake update for protected/private (#3446)#3772
Updates for Svc/PrmDb corresponding to UT cmake update for protected/private (#3446)#3772LeStarch merged 2 commits intonasa:develfrom
Conversation
|
|
||
| class PrmDbTester : public PrmDbGTestBase { | ||
| public: | ||
| PrmDbTester(Svc::PrmDbImpl& inst); |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning test
|
@LeStarch From my initial poking, the updates to use UT_AUTO_HELPERS seems like it would require enough further re-work of the existing Testers that I think it would be worth making that its own issue/task. |
| * requiring additional friendship declarations. It leverages the existing | ||
| * friendship between PrmDbImpl and PrmDbImplTester. | ||
| */ | ||
| class PrmDbImplTester { |
There was a problem hiding this comment.
Wasn't I expecting this to be renamed PrmDbTester? Or did I misunderstand?
There was a problem hiding this comment.
It looks like this may be entirely unused. Perhaps we can remove?
There was a problem hiding this comment.
We now have both PrmDbTester and PrmDbImplTester. (And what used to be PrmDbTester.cpp is now the TestMain file.)
PrmDbTesteris a friend ofPrmDbComponentBase- We use
PrmDbTesterto calldoDispatchwhich is declared private in PrmDbComponentBase (in PrmDbComponentAc.hpp) by doingthis->m_impl.doDispatch()from PrmDbTester
- We use
PrmDbImplTesteris a friend ofPrmDbImpl.- We use
PrmDbImplTesterto callclearDbwhich is declared private in PrmDbImpl (here) by doingthis->m_implTester.clearDb()from PrmDbTester. - We will get errors if trying to do
this->m_impl.clearDb()
- We use
|
I am going to move this back to draft to fix the naming inconsistencies. Will try to discuss with CogE on desired name and file pattern going forward. |
…private by updating driver name and updating PrmDbImplTester to PrmDbTester
Change Description
I locally updated
fprime/cmake/settings.cmaketo change-DPROTECTED=protected -DPRIVATE=private. This causes additional build errors beyond all our updates in manual code for PRIVATE->private and PROTECTED->protected due to auto-coded files which use PRIVATE, PROTECTED. This set of changes is associated with fixingSvc/PrmDbso that the UTs in this directory can build and pass.Approach in this case was:
Rationale
#3446
Future Work
fprime/cmake/settings.cmakeitself - this will be done at the end<X>Implto<X>(separate issue)