Merged
Conversation
LeStarch
previously approved these changes
Jun 18, 2025
Collaborator
LeStarch
left a comment
There was a problem hiding this comment.
I don't like this style as much as your other PRs. I prefer to have the tester control access to the private members' usage, rather than just adding in getters.
For now I am approving, because it isn't wrong to do it this way, just feels less clean.
thomas-bc
reviewed
Jun 18, 2025
…d checks into DpContainerTester itself
Contributor
Author
@LeStarch Updated the Tester to actually be doing some of the checks, ready for re-review |
LeStarch
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Updates to
fprime/Fw/Dp*to change:PRIVATE->privatePROTECTED->protectedRationale
#3446
Testing/Review Recommendations
N/A
Future Work
Additional PRs to be opened for further updates corresponding to #3446