CDHCore Subtopology improvements#3751
Merged
LeStarch merged 6 commits intonasa:develfrom Jun 18, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the fatal handler component from the Ref topology into the CDHCore subtopology, updates the configuration folder and related file references, and removes an unnecessary dependency from TestDeployment.
- Moved fatal handler instance and connection from Ref to CDHCore.
- Renamed the configuration folder from "CDHCoreConfig" to "config" and updated CMakeLists accordingly.
- Removed add_dependencies(TestDeployment ...) based on recent CMake improvements.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmake/test/data/TestDeployment/CMakeLists.txt | Removed obsolete add_dependencies for Svc_Subtopologies_CDHCore. |
| Svc/Subtopologies/CDHCore/config/config.fpp | Added fatalHandler instance with updated configuration and comment note. |
| Svc/Subtopologies/CDHCore/config/CMakeLists.txt | Updated file reference from CDHCoreConfig.fpp to config.fpp. |
| Svc/Subtopologies/CDHCore/CMakeLists.txt | Updated subdirectory reference from CDHCoreConfig to config. |
| Svc/Subtopologies/CDHCore/CDHCore.fpp | Added fatalHandler instance and its connection in the FaultProtection block. |
| Ref/Top/topology.fpp | Removed fatalHandler instance and its connection from the Ref topology. |
| Ref/Top/instances.fpp | Removed fatalHandler instance and modified comDriver’s base id. |
LeStarch
requested changes
Jun 17, 2025
LeStarch
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Reftopology to theCDHCoresubtopologyCDHCoreConfig->config. The fpp file and its references in CMakeLists have also been changed accordingly. This structure will continue in future subtopologies.