Fix compilation when FW_QUEUE_REGISTRATION == 0#3746
Merged
LeStarch merged 2 commits intonasa:develfrom Jun 17, 2025
Merged
Conversation
LeStarch
approved these changes
Jun 17, 2025
| namespace Os { | ||
|
|
||
| FwSizeType Queue::s_queueCount = 0; | ||
| #if FW_QUEUE_REGISTRATION |
Check notice
Code scanning / CodeQL
Conditional compilation Note
| this->m_size = messageSize; | ||
| ScopeLock lock(Queue::getStaticMutex()); | ||
| Queue::s_queueCount++; | ||
| #if FW_QUEUE_REGISTRATION |
Check notice
Code scanning / CodeQL
Conditional compilation Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
When FW_QUEUE_REGISTRATION is 0, Os::Queue::s_queueRegistry cannot be defined or accessed, because it is not declared in
Os/Queue.hpp. It results in a compilation error.Rationale
F Prime's supported configuration options should not cause the build to fail.
Testing/Review Recommendations
n/a
Future Work