PRIVATE -> private for Utils/Types/CircularBuffer.hpp#3743
Merged
LeStarch merged 4 commits intonasa:develfrom Jun 18, 2025
Merged
PRIVATE -> private for Utils/Types/CircularBuffer.hpp#3743LeStarch merged 4 commits intonasa:develfrom
LeStarch merged 4 commits intonasa:develfrom
Conversation
m-aleem
commented
Jun 17, 2025
| (void)generate_random_fprime_frame(circular_buffer); | ||
| circular_buffer.m_allocated_size--; // Remove 1 byte from the end of the frame to trigger "more data needed" | ||
| // Remove 1 byte from the end of the frame to trigger "more data needed" | ||
| Types::CircularBufferTester::tester_m_allocated_size_decrement(circular_buffer); |
Contributor
Author
There was a problem hiding this comment.
@thomas-bc brought up a good discussion point that we could alternatively make FrameAccumulatorTester directly a friend of CircularBuffer instead of using CircularBufferTester here (since FrameAccumulator uses the TEST (fixture-less) macro with calls to FrameAccumulatorTester).
In this case, is there's a reason to prefer that approach over this (or vice-versa)? I think I recall some discussion of the friendship pattern (limit?) .e.g. for X have XTester be the friend, so I guess that is an argument for the approach already shown here, but want to double check. @LeStarch ?
Collaborator
|
CI should be fixed by merging latest |
thomas-bc
approved these changes
Jun 17, 2025
LeStarch
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Updates to
Utils/Types/CircularBuffer.hpp*to change:PRIVATE->privatePROTECTED->protectedRationale
#3446
Testing/Review Recommendations
N/A
Future Work
Additional PRs to be opened for further updates corresponding to #3446