feat: use config header for CRC filename size#3708
Merged
LeStarch merged 8 commits intonasa:develfrom Jun 18, 2025
0xb-s:0xb-s-patch-1
Merged
feat: use config header for CRC filename size#3708LeStarch merged 8 commits intonasa:develfrom 0xb-s:0xb-s-patch-1
LeStarch merged 8 commits intonasa:develfrom
0xb-s:0xb-s-patch-1
Conversation
0xb-s
commented
Jun 9, 2025
LeStarch
requested changes
Jun 11, 2025
Collaborator
LeStarch
left a comment
There was a problem hiding this comment.
Additional improvement suggestion. Otherwise this is an excellent fix!
LeStarch
previously approved these changes
Jun 11, 2025
Collaborator
LeStarch
left a comment
There was a problem hiding this comment.
Ran CI, may need a cast but CI will tell.
LeStarch
approved these changes
Jun 16, 2025
Collaborator
LeStarch
left a comment
There was a problem hiding this comment.
I removed the extra definition of the size in the config, since it was removed in the code. Once CI passes, we'll merge!
Thanks!
|
|
||
| static const FwSignedSizeType CRC_FILE_READ_BLOCK = 2048; | ||
| static const U32 CRC_MAX_FILENAME_SIZE = 128; // TODO use a config variable | ||
| static const FwSignedSizeType CRC_FILE_READ_BLOCK = CONFIG_CRC_FILE_READ_BLOCK ; |
Check warning
Code scanning / CppCheck
Extra space before last semicolon. If this should be an empty statement, use {} instead. Warning
Contributor
Author
Thank you ! let me know if any additional changes are needed. |
thomas-bc
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced hardcoded CRC_MAX_FILENAME_SIZE with value from CRCCheckerConfig.hpp.