PRIVATE->private and PROTECTED->protected updates in FppTest/component (nasa#3446)#3686
Merged
LeStarch merged 1 commit intonasa:develfrom Jun 3, 2025
Merged
PRIVATE->private and PROTECTED->protected updates in FppTest/component (nasa#3446)#3686LeStarch merged 1 commit intonasa:develfrom
LeStarch merged 1 commit intonasa:develfrom
Conversation
Contributor
Author
|
UTs passed when I ran locally, but in CI timing test |
Collaborator
|
There's likely a way to improve the UT design so that it should deterministically succeed, but it hasn't been enough of an issue that we would prioritize to improve on it. |
LeStarch
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Updates to
fprime/FppTest/component:PRIVATE->privateRationale
#3446
Testing/Review Recommendations
Testing Conducted: I ran the following inside FppTest:
fprime-util generate --ut;fprime-util build --ut;fprime-util checkand ensured no failures.