Initial refactor to allow implementations as object libraries#3642
Merged
LeStarch merged 9 commits intonasa:develfrom May 23, 2025
Merged
Initial refactor to allow implementations as object libraries#3642LeStarch merged 9 commits intonasa:develfrom
LeStarch merged 9 commits intonasa:develfrom
Conversation
thomas-bc
reviewed
May 21, 2025
a7c127d to
c855d06
Compare
200821f to
9c00ecd
Compare
thomas-bc
reviewed
May 23, 2025
Collaborator
thomas-bc
left a comment
There was a problem hiding this comment.
Questions and code comments to be removed, but otherwise lgtm!
We should make sure to update https://github.com/nasa/fprime/blob/devel/docs/user-manual/build-system/package-implementations.md before we release 4.0
|
|
||
|
|
||
| # Non-test directory | ||
| add_fprime_subdirectory("${CMAKE_CURRENT_LIST_DIR}/GTest") |
Collaborator
There was a problem hiding this comment.
[Unrelated to PR]. Funny, I didn't even know this existed but that GTest::Bytes::compare() is pretty nifty. I can't find anywhere in the code where it's used... maybe in the FPP assert code?
thomas-bc
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Changes implementations from raw source files to object libraries. This speeds up the UT build.